Paul Durrant wrote: > Min Miles Xu wrote: >>> That's true; I was not thinking of LSO specifically. Actually, I have >>> not looked when m_getcapab() is called these days - it may be that >>> you only have to unplumb/replumb the stack to enable TSO. >> >> That may not be true. m_getcapab() seems not to be called again when >> the interface is unplumb/plumb. > > That sounds like a bug. The stack should really check each time it > plumbs; or provide an interface for TSO enable/disable as Drew mentions > that other OSes do.
FWIW, unplub/plumb is still not much better than the current situation of removing/adding the driver. Every other OS lets you change these settings on the fly, potentially without even taking the NIC down. (assuming the NIC hardware doesn't require a reset; and even if it does, that reset happens without administrator intervention). I think there needs to be a m_setcapap() or something similar to notify drivers of what capabilities are enabled. Drew _______________________________________________ networking-discuss mailing list [email protected]
