Garrett,

Looking through mii.h...

The interfaces for some functions have you passing 8 and 16bit types
as well as 8/16bit types in some structures. Are there particular requirements
for the use of such small types?

If mii_reset is optional, providing a "mii_reset_nop" function for folks
to use in their driver (rather than a NULL) may make the infrastructure
eaiser? (a NULL function pointer becomes a bug)

Given that -1 isn't used, shouldn't mii_get_speed() return uint32_t?
Thoughts on it returning uint64_t and returning kbps instead of mbps?

Darren

_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to