On Tue, Jun 02, 2009 at 10:50:44AM -0400, [email protected] wrote:
> On (06/02/09 10:20), James Carlson wrote:
> > 
> > It'd be nice to be doing bit tests with "!" rather than "== 0".  The
> > former seems much more legible to me.
> > 
> 
> Do you mean this:
> 
>   if (!(nce->nce_flags & NCE_F_PERMANENT)) {

I think he does.  For flag-values, this is probably preferred.

> (I have seen both styles used in the code, in different places)

Interesting, but I agree with Jim, as your example here illustrates.

Dan
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to