Peter Memishian wrote:
> many thanks for the detailed review! I'm going
> to work through your netcfgd code review comments
> first if that's okay. We probably won't publish
> a complete updated webrev for a little while since we want
> to address as much of the feedback as possible, but
> I've placed an updated webrev which includes these
> changes at:
>
> http://zhadum.east/export/ws/amaguire/nwam1-bugs/webrev/
Alan,
The changes look good -- 150 fewer lines, too. I have a few additional
ones below in addition to the Makefile comments I sent you separately.
* General Seems cumbersome to be sending getopt() processing
failures to syslog. Further, most daemons running in the
foreground write to stderr. As such, I'd expect (a) syslog
to only be used when running as a daemon and (b) nlog() to
use fprintf() or syslog() as appropriate.
I've modified nlog() and the usage error
to write to stderr (the former only if netcfgd
is running in the foreground of course).
* 28-36: nit: Rejustify the comment to wrap at 79 columns and it
should format a bit better.
* 170: Default disposition of SIGTHAW is SIG_IGN, so this seems
unnecessary.
sure. I also tidied up the Makefile in line with
your other suggestions - see:
http://zhadum.east.sun.com/export/ws/amaguire/nwam1-bugs/webrev/
...for the latest version with these changes.
> I haven't addressed the issue of moving netcfgd to
> usr/src/cmd/netcfgd here yet, though I agree it's a good
I don't recall suggesting that; I'm fine with its current location.
my mistake - that was a code review comment from
Sowmini, based upon the precedent set by dlmgmtd.
Thanks again for all the help!
Alan
_______________________________________________
networking-discuss mailing list
[email protected]
