On 26/08/09 09:00 PM, Sebastien Roy wrote:
On Wed, 2009-08-26 at 20:53 -0700, Darren Reed wrote:
On 26/08/09 08:41 PM, Sebastien Roy wrote:
On Wed, 2009-08-26 at 19:42 -0700, Yunsong (Roamer) Lu wrote:
Yes, to determine the packet is a LSO one, snoop needs to get the meta data. It's certain that snoop shouldn't regard any large(>MTU) packets as LSO ones. :)
Seeing as snoop currently doesn't know the MTU
What makes you say that?

Doesn't dlpi_info() return that in snoop_capture.c`open_datalink?

Or am I missing something?

It's di_max_sdu that gets used, not mtu_size, throughout the code...

This, however, seems a bit... bogus...
        /* for backward compatibility, allow known interface mtu_sizes
*/
        if (interface->mtu_size > dlinfo.di_max_sdu)
                dlinfo.di_max_sdu = interface->mtu_size;

Ah, this is what I was thinking of.  Bogus indeed.  Does that get saved
into the capture file?

You're going to love this...

from snoop_capture.c`cap_open_read:

       dlinfo.di_max_sdu = MAXINT;     /* Decode any stored packet. */

Darren

_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to