All,
Hopefully this is the final code review for this CR. I think this addresses
all the comments from Nico, Tom and Mark. The complete webreview is available
at:
http://cr.opensolaris.org/~johnfisc/nodename-6974969/
A diff-ed webreview from the last email is available at:
http://cr.opensolaris.org/~johnfisc/nodename-6974969-diffs/
A diff-ed webreview from the original webreview is available at:
http://cr.opensolaris.org/~johnfisc/nodename-6974969-diffs-orig/
Thanks,
John
----- Original Message -----
From: tom.whit...@oracle.com
To: john.fisc...@oracle.com
Cc: networking-discuss@opensolaris.org, smf-disc...@opensolaris.org
Sent: Monday, August 9, 2010 10:11:30 AM GMT -08:00 US/Canada Pacific
Subject: Re: [networking-discuss] [smf-discuss] Code review request for CR
6974969 [PSARC/2010/223]
On Mon, Aug 09, 2010 at 08:56:54AM -0700, John Fischer wrote:
> Tom and Nico (et. al.),
>
> I have updated the webrev based upon feedback provided.
> The new webrev is located at:
>
> http://cr.opensolaris.org/~johnfisc/nodename-6974969
>
> I have also posted a diffs webrev at:
>
> http://cr.opensolaris.org/~johnfisc/nodename-6974969.diffs
>
> If I can get this review completed early this week I think
> that I can get this back into ON before Monday.
>
> Thanks,
>
> John
John,
I'm sorry that I didn't have a chance to respond to your query before you
sent out the webrev. In usr/src/cmd/svc/milestone/identity.xml, the extra
decoration should go in the <templates> section. You probably want to do
something like this:
<template>
...
</documentation>
<pg_pattern name="config" type="application>
<description>
<loctext xml:lang='C'>
Properties that control the configuration of the node
</loctext>
</description>
<prop_pattern name="nodename" type="astring">
<description>
<loctext xml:lang='C'>
Network name of the computer
</loctext>
</description>
</prop_pattern>
</pg_pattern>
</template>
Feel free to change the actual text of the messages.
The rest of the changes look good to me, but I'm by no means a ksh expert.
tom
_______________________________________________
networking-discuss mailing list
networking-discuss@opensolaris.org
