Garrett D'Amore wrote: > On Fri, 2011-03-18 at 07:40 -0400, James Carlson wrote: >> Garrett D'Amore wrote: > > >> (I think others who have looked at it have felt that doing this wasn't >> as important as rewriting "sppp" to use the MAC layer. I have no real >> opinion about that. But the last time I looked at that code, it was >> also very Ethernet-centric and would have required a good bit of work. >> Perhaps Clearview and others have fixed this.) > > Making sppp use MAC would be good, but yeah, I think its a bigger job. > >> If there's someone now with the time to make DL_PPP come to life, then >> please do change it. >> > > Making the DL_PPP datalink supported looks like it would be nearly > trivial -- mostly two lines in a table in snoop, the new define in > sys/dlpi.h, and gutting a lot of logic to improperly fake ethernet > headers in sppp itself.
Don't forget ip_m_tbl in ip_if.c. PPP will break if you don't update that. You'll probably need to check to make sure that dladm and ifconfig and other things using libdladm and/or libdlpi still "work" for the new PPP interfaces. Or at least that they don't break too badly. Someone will need to update ethereal, or that'll break as well. Need to check on the "bpf" driver, IP Filter, and pfmod. These have long dealt only with Ethernet. Dunno if anyone wants PPP interfaces imported into Xen. If so, then xnbo will need updating. I seem to recall that the SNMP agent had assumptions in it about Ethernet, but I can't check that because it's closed source. Someone at Oracle will need to do that. At a minimum, someone should check that it doesn't just drop core. ;-} I would expect that nwam _might_ be surprised by these interfaces. Also worth a test. Offhand, I don't recall all the places that had strange Ethernet assumptions. I do remember that there were many of them hidden around the system, and that it'll likely take a good bit of searching to locate them all. -- James Carlson 42.703N 71.076W <carls...@workingcode.com> _______________________________________________ networking-discuss mailing list networking-discuss@opensolaris.org
