On Mon, 2008-03-03 at 21:36 +0100, Michael Biebl wrote: > Hi, > > today I've taken a look a the pkgconfig files of NM 0.6 and 0.7, > specifically the Requires lines, and I noticed what I think are errors. > Patches for trunk and 0.6 branch are attached. See also man pkg-config. > > For libnm-(glib,util), I interpreted Requires as "package that must be > installed to successfully compile a test program using this lib" (1) > > 0.7: > libnm-glib/libnm_glib.pc.in > The installed header files (libnm-glib/*.h) include glib and dbus-glib > headers > -> added glib-2.0 and dbus-glib-1 > > libnm-util/nm-utils.h includes dbus/dbus.h > Either remove this include or add dbus-1 to libnm-utils.pc.in. As it > compiles fine withoug dbus/dbus.h, I chose the former. > > NetworkManager.pc.in > The installed header files (includes/*.h) do not include any dbus headers > -> Remove dbus-1 > Note: I know that NetworkManager.pc does not really represent a library, > and this metadata could have a different purpose. If so, please clarify > that.
Committed the 0.7 bits, thanks. > 0.6: > NetworkManager.pc.in > The installed header files (include/*) do not include any dbus or > libnm-utils headers > -> Remove dbus-1 libnm-util > See my note above. > > gnome/libnm_glib/libnm_glib.pc.in > The installed header files do not include any dbus for dbus-glib headers > -> Remove dbus-1 dbus-glib1 > > Note: I omitted nm-vpn-ui-interface.h deliberatly, to not include any > gtk deps. > > libnm-util/libnm-util.pc.in > The installed header files include dbus headers, not glib > -> Replace glib-2.0 with dbus-1 Committed; but... I guess we should be putting stuff that we _link_ to but don't expose through our headers into the completely undocumented Requires.private. Dan > > > Please review and apply > > > Michael > > _______________________________________________ > NetworkManager-list mailing list > [email protected] > http://mail.gnome.org/mailman/listinfo/networkmanager-list _______________________________________________ NetworkManager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
