Am Montag, 17. März 2008 18:06:18 schrieb Tambet Ingo: > On Mon, Mar 17, 2008 at 11:02 AM, Helmut Schaa <[EMAIL PROTECTED]> wrote: > > Why not call it in real_act_stage3_ip_config_start as it is done when > > using DHCP? That would be much clearer, no? > > It's much cleaner to not keep dhcp manager around when a device is > deactivated. It's not only cleaner, it's a bug not to do it there.
The decision is up to you :) Nevertheless I want to give you an hypothetical scenario why I would prefer it to be set in real_act_stage3_ip_config_start: As far as I can see nm_device_set_use_dhcp is defined in nm_device.h and could therefore be used from some places outside nm_device.cpp. It would be possible to call nm_device_set_use_dhcp even if the device is down. Afterwards starting a non-dhcp connection on that device would lead to the initial problem. Setting it in real_act_stage3_ip_config_start would avoid such issues. Helmut _______________________________________________ NetworkManager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
