On Fri, 2009-04-17 at 03:52 +0200, Michael Biebl wrote: > Oliver Falk wrote: > > Hi list! > > > > For reference: https://bugzilla.redhat.com/show_bug.cgi?id=464760 > > > > While trying to compile NM-1:0.7.0-0.11.svn4022.2 on alpha, I ran into a > > compile error: > > > > """ > > nm-serial-device.c: In function 'nm_serial_device_open': > > nm-serial-device.c:348: error: array subscript is above array bounds > > nm-serial-device.c:349: error: array subscript is above array bounds > > """ > > > > After analysing the problem, I found out that stdbuf is defined as "struct > > termio". Take a look at termio.h: > > """ > > [oli...@kriek ~]$ cat /usr/include/termio.h > > /* Compatible <termio.h> for old `struct termio' ioctl interface. > > This is obsolete; use the POSIX.1 `struct termios' interface > > defined in <termios.h> instead. */ > > > > #include <termios.h> > > #include <sys/ioctl.h> > > """ > > > > A simple fix - at least for alpha - is to use "struct termios" instead (I'll > > include a patch!). However, I have not tested this on x86 or any other > > platform - this is up to you! :-) > > > > I've attached a more complete patch (based on the NM-0_7 branch), which > replaces > the struct termio ioctl calls completely. > The 0.7.1 package now builds fine again on alpha [1]. > > Please review and apply.
Done: 31a34fa7ffbceb79d5e6c16158e5dcce285dcff1 Thanks! Dan _______________________________________________ NetworkManager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
