2010/2/27 Dan Williams <[email protected]>

> On Fri, 2010-02-26 at 21:17 +0800, cee1 wrote:
> >         The connection editor should support this as long as a system
> >         settings
> >         plugin is enabled that supports writing out VPN connections.
> >          At the
> >         moment the only plugin that does support this is the 'keyfile'
> >         plugin.
> >         Look in /etc/NetworkManager/nm-system-settings.conf to see if
> >         it's
> >         enabled.
> >
> > The keyfile plugin is enabled.
> >
> >
> > It seems connection editor doesn't support this:
> > For nm-connect-editor, only the function
> > "save_secrets" (network-manager-pptp-0.7.2/properties/nm-pptp.c) will
> > read user-entered password, and this function is only called for user
> > scope setting.
>
> Looks like you're right for NM-pptp; though for NM-vpnc this is
> correctly handled in update_connection().  We'll have to fix that.

Patch for nm-pptp
(nm-pptp_Store-password-in-update_connection-for-global-setti.patch)

BTW, for nm-openvpn, code of saving secret in system scope seems with the
same problem, another patch is given.
(nm-openvpn_Store-password-in-update_connection-for-global-setti.patch)
Note:

   - Unlike patch for nm-pptp, this patch is only compiling pass, not tested
   in practice currently.
   - The original code will call "nm_setting_vpn_add_secret" in
   
hash_copy_advanced<http://git.gnome.org/browse/network-manager-openvpn/tree/properties/nm-openvpn.c#n393>,
   seems nonsense (if in user scope, not needed, otherwise, the patch will call
   it later) and removes.



-- 
Regards,

- cee1

Attachment: nm-pptp_Store-password-in-update_connection-for-global-setti.patch
Description: Binary data

Attachment: nm-openvpn_Store-password-in-update_connection-for-global-setti.patch
Description: Binary data

_______________________________________________
networkmanager-list mailing list
[email protected]
http://mail.gnome.org/mailman/listinfo/networkmanager-list

Reply via email to