unsubscribe
On Mon, May 9, 2011 at 4:41 PM, <[email protected]>wrote: > Send networkmanager-list mailing list submissions to > [email protected] > > To subscribe or unsubscribe via the World Wide Web, visit > http://mail.gnome.org/mailman/listinfo/networkmanager-list > or, via email, send a message with subject or body 'help' to > [email protected] > > You can reach the person managing the list at > [email protected] > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of networkmanager-list digest..." > > > Today's Topics: > > 1. Re: [nm-applet][0.8.4][PATCH] trivial: fix possible > uninitialized variable usage (Paul Menzel) > 2. Re: [nm-applet][0.8.4][PATCH] trivial: fix possible > uninitialized variable usage (Dan Williams) > 3. Re: uClibc: nm-utils.h:30:22: fatal error: execinfo.h: No > such file or directory (Paul Menzel) > 4. [PATCH] Suppress duplicate SMS notifications (Nathan Williams) > 5. Re: [nm-applet][0.8.4][PATCH] trivial: fix possible > uninitialized variable usage (Paul Menzel) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Mon, 09 May 2011 21:50:26 +0200 > From: Paul Menzel <[email protected]> > To: [email protected] > Subject: Re: [nm-applet][0.8.4][PATCH] trivial: fix possible > uninitialized variable usage > Message-ID: <1304970626.3939.44.camel@mattotaupa> > Content-Type: text/plain; charset="utf-8" > > Am Montag, den 09.05.2011, 13:17 -0500 schrieb Dan Williams: > > On Mon, 2011-05-09 at 13:15 +0200, Paul Menzel wrote: > > > Date: Thu, 27 Jan 2011 10:59:37 -0600 > > > > > > [?] > > > arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 > -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb > --sysroot=/oe/build-angstrom-next/angstrom-dev/s > > > ysroots/armv7a-angstrom-linux-gnueabi -DHAVE_CONFIG_H -I. -I.. > -pthread -DORBIT2=1 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/incl > > > ude/dbus-1.0 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/dbus-1.0/include > -I/oe/build-angstrom-next/angstrom-dev/sysro > > > ots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include > -I/home/paul > > > > /oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/NetworkManager > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-lin > > > ux-gnueabi/usr/include/libnm-glib > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gtk-2.0 > -I/oe/build-angstrom-next/an > > > > gstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/gtk-2.0/include > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/atk-1. > > > 0 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/cairo > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstro > > > m-linux-gnueabi/usr/include/pango-1.0 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/pixman-1 > -I/oe/build-angstrom-ne > > > > xt/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/freetype2 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/lib > > > png12 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gconf/2 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-a > > > ngstrom-linux-gnueabi/usr/include/orbit-2.0 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gnome-keyring-1 > -DICONDIR=\""/usr > > > /share/icons"\" -DUIDIR=\""/usr/share/nm-applet"\" > -DBINDIR=\""/usr/bin"\" -DSYSCONFDIR=\""/etc"\" > -DLIBEXECDIR=\""/usr/libexec"\" -DAUTOSTARTDIR=\""/etc/xdg/autostart"\" > -DVPN_NAM > > > E_FILES_DIR=\""/etc/NetworkManager/VPN"\" > -DNMALOCALEDIR=\"/usr/share/locale\" -DG_DISABLE_DEPRECATED > -DG_DISABLE_SINGLE_INCLUDES -DATK_DISABLE_DEPRECATED > -DATK_DISABLE_SINGLE_INC > > > LUDES -DPANGO_DISABLE_DEPRECATED -DPANGO_DISABLE_SINGLE_INCLUDES > -DGDK_DISABLE_DEPRECATED -DGDK_DISABLE_SINGLE_INCLUDES > -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_SINGLE_ > > > INCLUDES -DGTK_DISABLE_DEPRECATED -DGTK_DISABLE_SINGLE_INCLUDES > -DGCONF_DISABLE_DEPRECATED -DGCONF_DISABLE_SINGLE_INCLUDES > -DBONOBO_DISABLE_DEPRECATED -DBONOBO_DISABLE_SINGLE_INCLU > > > DES -DBONOBO_UI_DISABLE_DEPRECATED > -DBONOBO_UI_DISABLE_SINGLE_INCLUDES -DGNOME_DISABLE_DEPRECATED > -DGNOME_DISABLE_SINGLE_INCLUDES -DLIBGLADE_DISABLE_DEPRECATED > -DLIBGLADE_DISABLE_S > > > INGLE_INCLUDES -DVTE_DISABLE_DEPRECATED > -DVTE_DISABLE_SINGLE_INCLUDES -DGNOME_VFS_DISABLE_DEPRECATED > -DGNOME_VFS_DISABLE_SINGLE_INCLUDES -DWNCK_DISABLE_DEPRECATED > -DWNCK_DISABLE_SI > > > NGLE_INCLUDES -DLIBSOUP_DISABLE_DEPRECATED > -DLIBSOUP_DISABLE_SINGLE_INCLUDES -I../src/marshallers -I../src/utils > -I../src/gconf-helpers -I../src/wireless-security -Wall -Werror - > > > std=gnu89 -fexpensive-optimizations -fomit-frame-pointer > -frename-registers -O2 -ggdb2 -Wshadow -Wmissing-declarations > -Wmissing-prototypes -Wdeclaration-after-statement -Wfloat-eq > > > ual -Wno-unused-parameter -Wno-sign-compare -fno-strict-aliasing > -MT nm_applet-applet-dialogs.o -MD -MP -MF > .deps/nm_applet-applet-dialogs.Tpo -c -o nm_applet-applet-dialogs.o `tes > > > t -f 'applet-dialogs.c' || echo './'`applet-dialogs.c > > > [?] > > > cc1: warnings being treated as errors > > > applet-dialogs.c: In function 'applet_info_dialog_show': > > > applet-dialogs.c:331:22: error: 'method' may be used uninitialized > in this function > > > make[3]: *** [nm_applet-applet-dialogs.o] Error 1 > > > --- > > > Unfortunately this patch is only in master and was not applied to 0.8.4 > > > so that the build fails with the above error message [1]. Therefore in > > > OpenEmbedded we need to pass `--enable-more-warings=no` to `configure`. > > > > > > This is a cherry-pick from master to a branch based on the tag 0.8.4. > > > > Yeah, that got fixed in commit bbe547f7985498e0bc353ccd2e8e6f9a4a89249b > > right after 0.8.4 was released; > > Strange. > > I cherry picked > > commit cc472cea1021dee90714703380a79e326aa0e681 > Author: Dan Williams <[email protected]> > Date: Thu Jan 27 10:59:37 2011 -0600 > > trivial: fix possible uninitialized variable usage > > which seems to address the exact same issues. Do you know why I cannot > find the commit you referenced in any branch? > > $ git branch --contains cc472cea1021dee90714703380a79e326aa0e681 > master > $ git branch --contains bbe547f7985498e0bc353ccd2e8e6f9a4a89249b > $ git --version > git version 1.7.5.1 > > > we probably should do a 0.8.6 soon just for kicks anyway. Not a bad > > idea to speed up releases and get good fixes out sooner. > > I second that idea. > > > Thanks, > > Paul > -------------- next part -------------- > A non-text attachment was scrubbed... > Name: signature.asc > Type: application/pgp-signature > Size: 198 bytes > Desc: This is a digitally signed message part > URL: < > http://mail.gnome.org/archives/networkmanager-list/attachments/20110509/3cfc320d/attachment.bin > > > > ------------------------------ > > Message: 2 > Date: Mon, 09 May 2011 15:08:17 -0500 > From: Dan Williams <[email protected]> > To: Paul Menzel <[email protected]> > Cc: [email protected] > Subject: Re: [nm-applet][0.8.4][PATCH] trivial: fix possible > uninitialized variable usage > Message-ID: <[email protected]> > Content-Type: text/plain; charset="UTF-8" > > On Mon, 2011-05-09 at 21:50 +0200, Paul Menzel wrote: > > Am Montag, den 09.05.2011, 13:17 -0500 schrieb Dan Williams: > > > On Mon, 2011-05-09 at 13:15 +0200, Paul Menzel wrote: > > > > Date: Thu, 27 Jan 2011 10:59:37 -0600 > > > > > > > > [?] > > > > arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 > -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb > --sysroot=/oe/build-angstrom-next/angstrom-dev/s > > > > ysroots/armv7a-angstrom-linux-gnueabi -DHAVE_CONFIG_H -I. -I.. > -pthread -DORBIT2=1 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/incl > > > > ude/dbus-1.0 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/dbus-1.0/include > -I/oe/build-angstrom-next/angstrom-dev/sysro > > > > ots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include > -I/home/paul > > > > > /oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/NetworkManager > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-lin > > > > ux-gnueabi/usr/include/libnm-glib > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gtk-2.0 > -I/oe/build-angstrom-next/an > > > > > gstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/gtk-2.0/include > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/atk-1. > > > > 0 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/cairo > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstro > > > > m-linux-gnueabi/usr/include/pango-1.0 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/pixman-1 > -I/oe/build-angstrom-ne > > > > > xt/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/freetype2 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/lib > > > > png12 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gconf/2 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-a > > > > ngstrom-linux-gnueabi/usr/include/orbit-2.0 > -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gnome-keyring-1 > -DICONDIR=\""/usr > > > > /share/icons"\" -DUIDIR=\""/usr/share/nm-applet"\" > -DBINDIR=\""/usr/bin"\" -DSYSCONFDIR=\""/etc"\" > -DLIBEXECDIR=\""/usr/libexec"\" -DAUTOSTARTDIR=\""/etc/xdg/autostart"\" > -DVPN_NAM > > > > E_FILES_DIR=\""/etc/NetworkManager/VPN"\" > -DNMALOCALEDIR=\"/usr/share/locale\" -DG_DISABLE_DEPRECATED > -DG_DISABLE_SINGLE_INCLUDES -DATK_DISABLE_DEPRECATED > -DATK_DISABLE_SINGLE_INC > > > > LUDES -DPANGO_DISABLE_DEPRECATED -DPANGO_DISABLE_SINGLE_INCLUDES > -DGDK_DISABLE_DEPRECATED -DGDK_DISABLE_SINGLE_INCLUDES > -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_SINGLE_ > > > > INCLUDES -DGTK_DISABLE_DEPRECATED -DGTK_DISABLE_SINGLE_INCLUDES > -DGCONF_DISABLE_DEPRECATED -DGCONF_DISABLE_SINGLE_INCLUDES > -DBONOBO_DISABLE_DEPRECATED -DBONOBO_DISABLE_SINGLE_INCLU > > > > DES -DBONOBO_UI_DISABLE_DEPRECATED > -DBONOBO_UI_DISABLE_SINGLE_INCLUDES -DGNOME_DISABLE_DEPRECATED > -DGNOME_DISABLE_SINGLE_INCLUDES -DLIBGLADE_DISABLE_DEPRECATED > -DLIBGLADE_DISABLE_S > > > > INGLE_INCLUDES -DVTE_DISABLE_DEPRECATED > -DVTE_DISABLE_SINGLE_INCLUDES -DGNOME_VFS_DISABLE_DEPRECATED > -DGNOME_VFS_DISABLE_SINGLE_INCLUDES -DWNCK_DISABLE_DEPRECATED > -DWNCK_DISABLE_SI > > > > NGLE_INCLUDES -DLIBSOUP_DISABLE_DEPRECATED > -DLIBSOUP_DISABLE_SINGLE_INCLUDES -I../src/marshallers -I../src/utils > -I../src/gconf-helpers -I../src/wireless-security -Wall -Werror - > > > > std=gnu89 -fexpensive-optimizations -fomit-frame-pointer > -frename-registers -O2 -ggdb2 -Wshadow -Wmissing-declarations > -Wmissing-prototypes -Wdeclaration-after-statement -Wfloat-eq > > > > ual -Wno-unused-parameter -Wno-sign-compare -fno-strict-aliasing > -MT nm_applet-applet-dialogs.o -MD -MP -MF > .deps/nm_applet-applet-dialogs.Tpo -c -o nm_applet-applet-dialogs.o `tes > > > > t -f 'applet-dialogs.c' || echo './'`applet-dialogs.c > > > > [?] > > > > cc1: warnings being treated as errors > > > > applet-dialogs.c: In function 'applet_info_dialog_show': > > > > applet-dialogs.c:331:22: error: 'method' may be used uninitialized > in this function > > > > make[3]: *** [nm_applet-applet-dialogs.o] Error 1 > > > > --- > > > > Unfortunately this patch is only in master and was not applied to > 0.8.4 > > > > so that the build fails with the above error message [1]. Therefore > in > > > > OpenEmbedded we need to pass `--enable-more-warings=no` to > `configure`. > > > > > > > > This is a cherry-pick from master to a branch based on the tag 0.8.4. > > > > > > Yeah, that got fixed in commit bbe547f7985498e0bc353ccd2e8e6f9a4a89249b > > > right after 0.8.4 was released; > > > > Strange. > > > > I cherry picked > > > > commit cc472cea1021dee90714703380a79e326aa0e681 > > Author: Dan Williams <[email protected]> > > Date: Thu Jan 27 10:59:37 2011 -0600 > > > > trivial: fix possible uninitialized variable usage > > > > which seems to address the exact same issues. Do you know why I cannot > > find the commit you referenced in any branch? > > > > $ git branch --contains cc472cea1021dee90714703380a79e326aa0e681 > > master > > $ git branch --contains bbe547f7985498e0bc353ccd2e8e6f9a4a89249b > > $ git --version > > git version 1.7.5.1 > > It's on the NMA_0_8 branch, which is the stable 0.8.x series branch. Do > you have that branched locally? That could be the issue though I don't > know why; > > > http://git.gnome.org/browse/network-manager-applet/commit/?h=NMA_0_8&id=bbe547f7985498e0bc353ccd2e8e6f9a4a89249b > > Dan > > > > we probably should do a 0.8.6 soon just for kicks anyway. Not a bad > > > idea to speed up releases and get good fixes out sooner. > > > > I second that idea. > > > > > > Thanks, > > > > Paul > > _______________________________________________ > > networkmanager-list mailing list > > [email protected] > > http://mail.gnome.org/mailman/listinfo/networkmanager-list > > > > > ------------------------------ > > Message: 3 > Date: Mon, 09 May 2011 22:07:01 +0200 > From: Paul Menzel <[email protected]> > To: [email protected] > Subject: Re: uClibc: nm-utils.h:30:22: fatal error: execinfo.h: No > such file or directory > Message-ID: <1304971621.3939.53.camel@mattotaupa> > Content-Type: text/plain; charset="utf-8" > > Am Montag, den 09.05.2011, 13:35 -0500 schrieb Dan Williams: > > On Sat, 2011-05-07 at 23:35 +0200, Paul Menzel wrote: > > > > trying to use uClibc to build NetworkManager in OpenEmbedded [1] > > > (distribution: `minimal-uclibc` for `MACHINE = "beagleboard"`) fails > > > with the following error. > > > > > > According to this comment in GNOME BTS ticket 146693 [2] (regarding > > > aMule) it should be checked for the existence of `execinfo.h` in the > > > build system and if it is not available the backtrace calls should be > > > made a no op. > > > > > > Unfortunately I can not point you to a project already having the > > > appropriate checks implemented, but there should be some. > > > > > > Being able to compile NetworkManager using uClibc should make > > > NetworkManager attractive for some more embedded use cases. > > > > I have no idea why that's there for master (probably left over from the > > old nm_warn/nm_error/etc calls) so I've removed it there. > > Great. That was easy [1]. > > > I guess all we can do for 0.8.4 (since this is a public header, and we > > can't really #include <config.h> there since we don't distribute it) is > > try to use uclibc-specific defines to make the nm_print_backtrace() call > > be a noop if we're on uclibc? > > That sounds reasonable. You can use something like the following > > #if !defined(__UCLIBC__) > # include <execinfo.h> > #endif > > or whatever is needed. > > Thanks, > > Paul > > > [1] > http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=4ae83f2d93fa67f86f8437d4b0fec8bd2b63ee2d > -------------- next part -------------- > A non-text attachment was scrubbed... > Name: signature.asc > Type: application/pgp-signature > Size: 198 bytes > Desc: This is a digitally signed message part > URL: < > http://mail.gnome.org/archives/networkmanager-list/attachments/20110509/7732a8c9/attachment.bin > > > > ------------------------------ > > Message: 4 > Date: Mon, 9 May 2011 16:25:17 -0400 > From: Nathan Williams <[email protected]> > To: [email protected] > Subject: [PATCH] Suppress duplicate SMS notifications > Message-ID: <[email protected]> > Content-Type: text/plain; charset="iso-8859-1" > > On some modems, such as the Samsung Y3300, unsolicited notifications for > SMS > messages (+CMTI) are sent over both the primary and secondary ports. > Currently, this leads to multiple SmsReceived signals being sent. This > patch > de-dups the signals by tracking the index numbers that have been seen so > far. The data structure here could also be a basis for coalescing multipart > messages. > > - Nathan > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: < > http://mail.gnome.org/archives/networkmanager-list/attachments/20110509/2e2fb569/attachment.html > > > -------------- next part -------------- > A non-text attachment was scrubbed... > Name: 0001-modemmanager-Track-SMS-index-numbers-to-avoid-sendin.patch > Type: text/x-patch > Size: 2531 bytes > Desc: not available > URL: < > http://mail.gnome.org/archives/networkmanager-list/attachments/20110509/2e2fb569/attachment.bin > > > > ------------------------------ > > Message: 5 > Date: Mon, 09 May 2011 22:40:53 +0200 > From: Paul Menzel <[email protected]> > To: [email protected] > Subject: Re: [nm-applet][0.8.4][PATCH] trivial: fix possible > uninitialized variable usage > Message-ID: <1304973653.3939.78.camel@mattotaupa> > Content-Type: text/plain; charset="utf-8" > > Am Montag, den 09.05.2011, 15:08 -0500 schrieb Dan Williams: > > On Mon, 2011-05-09 at 21:50 +0200, Paul Menzel wrote: > > > Am Montag, den 09.05.2011, 13:17 -0500 schrieb Dan Williams: > > [?] > > > > > Yeah, that got fixed in commit > bbe547f7985498e0bc353ccd2e8e6f9a4a89249b > > > > right after 0.8.4 was released; > > > > > > Strange. > > > > > > I cherry picked > > > > > > commit cc472cea1021dee90714703380a79e326aa0e681 > > > Author: Dan Williams <[email protected]> > > > Date: Thu Jan 27 10:59:37 2011 -0600 > > > > > > trivial: fix possible uninitialized variable usage > > > > > > which seems to address the exact same issues. Do you know why I cannot > > > find the commit you referenced in any branch? > > > > > > $ git branch --contains > cc472cea1021dee90714703380a79e326aa0e681 > > > master > > > $ git branch --contains > bbe547f7985498e0bc353ccd2e8e6f9a4a89249b > > > $ git --version > > > git version 1.7.5.1 > > > > It's on the NMA_0_8 branch, which is the stable 0.8.x series branch. Do > > you have that branched locally? That could be the issue though I don't > > know why; > > > > > http://git.gnome.org/browse/network-manager-applet/commit/?h=NMA_0_8&id=bbe547f7985498e0bc353ccd2e8e6f9a4a89249b > > You are right, I did not have a local checkout. `-a` comes to the > rescue. > > $ git branch -a --contains > bbe547f7985498e0bc353ccd2e8e6f9a4a89249b > remotes/origin/NMA_0_8 > > > Thanks, > > Paul > -------------- next part -------------- > A non-text attachment was scrubbed... > Name: signature.asc > Type: application/pgp-signature > Size: 198 bytes > Desc: This is a digitally signed message part > URL: < > http://mail.gnome.org/archives/networkmanager-list/attachments/20110509/018820d2/attachment.bin > > > > ------------------------------ > > _______________________________________________ > networkmanager-list mailing list > [email protected] > http://mail.gnome.org/mailman/listinfo/networkmanager-list > > > End of networkmanager-list Digest, Vol 80, Issue 27 > *************************************************** > -- Benjamin J. Brandimarte "Own & Owe Limited" "be your own bank!"
_______________________________________________ networkmanager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
