On Tue, 2011-11-15 at 13:38 +0100, Jirka Klimes wrote: > On Friday 30 of September 2011 01:05:20 Dan Williams wrote: > > On Thu, 2011-09-29 at 20:59 +0400, Yury G. Kudryashov wrote: > > > Dan Williams wrote: > > > > On Tue, 2011-09-27 at 10:27 -0500, Dan Williams wrote: > > > >> Split config file reading and handling out of main.c so that it's > > > >> easier to extend later on. > > > > > > > > And I accidentally pushed them. So if anyone has comments, let me know > > > > and I'll push fixes. > > > > > > I saw that with the previous way of handling config file the plugins used > > > /etc/NetworkManager/NetworkManager.conf even if NetworkManager is started > > > with '-c' option. Is it still true? If yes, what about passing a 'config > > > file handle' to plugins? > > > > You're right, that's still true. What should probably happen here is > > that NMSettings should pass the config file path to the plugins when > > they get created. Either we modify the factory function > > (nm_system_config_factory) for each plugin, or we make the config file a > > GObject property on the plugins that gets set by NMSettings right after > > creating the plugin. I vote #1. Patches anyone? > > > > Solution #1 implemented, please review the patch.
Looks good to me. Dan _______________________________________________ networkmanager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
