On Fri, 2011-11-04 at 11:34 -0400, Dan Winship wrote: > This only implements the basics (ie, NMSettingInfiniband doesn't have > very many properties yet), but it does work for basic IPoIB setups. > > Re: the discussion in TODO about merging vs splitting with the > wired/ethernet code, it seemed to make more sense to split; most of the > ethernet-related properties don't apply to infiniband connections (in > particular, you can't do MAC address cloning, and of course all the s390 > stuff is superfluous), and infiniband will eventually have several of > its own properties, and so if we tried to merge them together, you'd end > up with this weird bimodal NMSettingWired class. So, I made > NMSettingInfiniband. > > On the daemon side, it also didn't make sense to merge them, but there > was a lot more shared code there than on the settings side. So I split > an NMDeviceWired out of NMDeviceEthernet, and then made NMDeviceEthernet > and NMDeviceInfiniband inherit from that. NMDeviceWired isn't visible to > the D-Bus interfaces though, and so libnm-glib gets a > NMDeviceInfiniband, but not an NMDeviceWired. > > This is slightly awkward in that now we have both NMSettingWired and > NMDeviceWired, which don't mean the same thing. It might make sense to > rename NMSettingWired to NMSettingEthernet? > > There will be more patches later, but I wanted to get the NMDeviceWired > split in now (assuming we are going to go with that rather than some > other solution) to avoid rebasing pain later.
Patches 1 & 2 pushed; waiting on the rebase to git master for the rest, thanks! Dan _______________________________________________ networkmanager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
