On Tue, 2012-02-07 at 10:57 +0100, Jirka Klimes wrote: > The patch adds "StateReason" property to libnm-glib's NMDevice > and a getter function nm_device_get_state_reason().
Actually, if you don't mind, could we change the public function here to: NMDeviceState nm_device_get_state_reason (NMDevice *device, NMDeviceStateReason *reason); then we can make NMDeviceStateReasonStruct private and not have to expose it in public API. If there were more elements in the structure I'd say yeah, we should look at exposing it, but for only two elements that are already long-defined I don't think its worth adding a new struct to the public bits. Feel free to push then when you're ready. Thanks! Dan _______________________________________________ networkmanager-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/networkmanager-list
