I revised the patch to clean up some more context objects in mm-modem-iface. Thanks.
On Wed, Jul 11, 2012 at 11:48 PM, Aleksander Morgado <[email protected]>wrote: > Hey Ben, > > > > > Yep, that works too. How about this? > > > > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > > index 49a18a5..7b44d6a 100644 > > --- a/src/mm-iface-modem.c > > +++ b/src/mm-iface-modem.c > > @@ -3676,6 +3676,14 @@ mm_iface_modem_shutdown (MMIfaceModem *self) > > { > > g_return_if_fail (MM_IS_IFACE_MODEM (self)); > > > > + /* Remove SignalQualityUpdateContext object to make sure any pending > > + * invocation of expire_signal_quality is canceled before the DBus > > skeleton > > > s/canceled/cancelled :-) > > > > + * is removed. */ > > + if (G_LIKELY (signal_quality_update_context_quark)) > > + g_object_set_qdata (G_OBJECT (self), > > + signal_quality_update_context_quark, > > + NULL); > > + > > /* Remove SIM object */ > > g_object_set (self, > > MM_IFACE_MODEM_SIM, NULL, > > > > Looks good. Are you able to update the patch including not only the > signal-quality context cleanup, but also the same cleanup for the other > contexts in the modem/3gpp/messaging/time... interfaces? If the signal > quality context has the issue, all the other contexts which set up > timeouts are also affected. > > -- > Aleksander > > >
_______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
