Sent a revised patch. update_signa_quality seems unaffected. Thanks, Ben
On Wed, Aug 1, 2012 at 11:05 AM, Aleksander Morgado <[email protected]>wrote: > Good catch :-) > > Are you able to update the patch including the same fix for the access > technologies loading? Suffers from the same issue. > > Also, if the context is not anymore available because we > disabled/shutdown the interface, I wouldn't also set the values > retrieved (e.g. skip calling > mm_iface_modem_update_[signal_quality|access_technologies]). > > > > On 08/01/2012 07:46 PM, Ben Chan wrote: > > --- > > src/mm-iface-modem.c | 7 +++++-- > > 1 files changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/src/mm-iface-modem.c b/src/mm-iface-modem.c > > index e3165f2..d49787f 100644 > > --- a/src/mm-iface-modem.c > > +++ b/src/mm-iface-modem.c > > @@ -843,9 +843,12 @@ signal_quality_check_ready (MMIfaceModem *self, > > } else > > update_signal_quality (self, signal_quality, TRUE); > > > > - /* Remove the running tag */ > > + /* Remove the running tag. Note that the context may have been > removed by > > + * mm_iface_modem_shutdown when this function is invoked as a > callback of > > + * load_signal_quality. */ > > ctx = g_object_get_qdata (G_OBJECT (self), > signal_quality_check_context_quark); > > - ctx->running = FALSE; > > + if (ctx) > > + ctx->running = FALSE; > > } > > > > static gboolean > > > > > -- > Aleksander >
_______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
