On Thu, Nov 01, 2012 at 07:32:14PM -0400, Pavel Simerda wrote: > > What is it supposed to fix?
This patch is for network-manager-pptp (should have mentioned that). It does not build against current GTK: $ ./configure && make [...] gcc -Wall -Werror [...] vpn-password-dialog.c vpn-password-dialog.c: In function ‘add_row’: vpn-password-dialog.c:127:2: error: ‘gtk_table_attach_defaults’ is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtktable.h:120): Use 'GtkGrid' instead [-Werror=deprecated-declarations] The autoconf script enables -Werror by default. The original bug report https://bugzilla.gnome.org/show_bug.cgi?id=679130 is dated 2012-06-29. So this has been an issue for a while, and the -Werror flag does not help anything besides breaking the build. I therefore suggest that -Werror be disabled by default. It can be re-enabled on the command line by running ./configure --enable-more-warnings=error. Eventually, the deprecations should be fixed as well. But I do not see a point in disabling a software that is working just fine. Regards, Clemens --- Additional info: networkmanager-pptp 0.9.6.0-1 gtk3 3.6.1-1 gcc 4.7.2-2 _______________________________________________ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list