Thanks Aleksander. My patch has a typo bug in unsolicited_registration_events_context_step where the eps_error variable in UnsolicitedRegistrationEventsContext is not properly set to NULL after the ownership of GError object pointed by eps_error is transfered. I've submitted a revised patch.
- Ben On Mon, Feb 11, 2013 at 11:47 PM, Aleksander Morgado <[email protected]>wrote: > On 02/11/2013 07:44 PM, Ben Chan wrote: > > Aleksander and Dan, > > > > How do you feel about this patch? > > > > > Doesn't look bad, but I really need to read it carefully as it changed > lots of things. The idea is that plugins can specify whether they > require CEREG by setting MM_IFACE_MODEM_3GPP_EPS_NETWORK_SUPPORTED to > TRUE themselves, instead of automatically trying it when LTE support is > found, right? I now wonder how other AT-controlled LTE modems out there, > not just the Novatel LTE, handle this. Is anyone willing to give it a > try with other LTE modems? > >
_______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
