On Friday 17 of May 2013 14:10:56 Colin Walters wrote: > On Fri, 2013-05-17 at 08:04 -0400, Pavel Simerda wrote: > > Colin, do you have any ideas for the NetworkManager codebase apart from > > the cleanup functions? > Possibly; the structured logging for example. NM could tag e.g. DHCP > log messages with the interface ID, and system management interfaces > could then show log messages related to that interface. > > > > If not, why don't we remove the submodule and just copy in the > > > header with the relevant macros for now? > > > > Or maybe we could make the build system only choose relevant parts from > > libgsystem. > Let me try a patch.
Colin, thanks for the "Build with GLib 2.32 as well" patch. But still, libgsystem doesn't compile due to g_clear_pointer(): CC libgsystem_la-gsystem-file-utils.lo libgsystem/gsystem-file-utils.c: In function 'linkcopy_internal_attempt': libgsystem/gsystem-file-utils.c:358:3: error: implicit declaration of function 'g_clear_pointer' [-Werror=implicit-function-declaration] cc1: all warnings being treated as errors We now use g_clear_pointer() as well, but define it for glib < 2.34 in include/nm-glib-compat.h Jirka _______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
