I recently reported an issue with NetworkManager that causes buggy and
unreliable network service to some PEAP networks if the wpa_supplicant
is not up to date (1.1 or higher). Because of this I think we should
check for the right version of wpa_tools at configure time to prevent
this issue. Worst case is it delays deployment on some systems like
debian which does not have wpasupplicant 1.1 yet

Bug report
https://bugzilla.gnome.org/show_bug.cgi?id=701342

Proposed patch is attatched

-Kevin
>From 409c7c828a221abcf06aead9cd3bf21ca8eadfa7 Mon Sep 17 00:00:00 2001
From: Kevin Brandstatter <[email protected]>
Date: Tue, 4 Jun 2013 21:51:59 +0200
Subject: [PATCH] Check for wpa_supplicant >= 1.1

---
 configure.ac |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/configure.ac b/configure.ac
index cc66e9b..b308201 100644
--- a/configure.ac
+++ b/configure.ac
@@ -479,6 +479,18 @@ else
 fi
 AM_CONDITIONAL(WITH_MODEM_MANAGER_1, test "${with_modem_manager_1}" = "yes")
 
+# Test for good version of wpa_supplicant
+AC_PATH_PROGS(with_wpa_supplicant, wpa_supplicant, no, /sbin:/usr/sbin:/usr/local/sbin)
+if test "$with_wpa_supplicant" != "no"; then
+      version=`"$with_wpa_supplicant" -v 2>&1 | grep -oP "\d?\.\d?"`
+      if test "$version" \< "1.1"; then
+         AC_MSG_ERROR([wpa_supplicant >= 1.1 required])
+      else
+         AC_MSG_RESULT([wpa_supplicant >= 1.1 found])
+      fi
+else
+      AC_MSG_ERROR([wpa_supplicant not found])
+fi
 # DHCP client support
 AC_ARG_WITH([dhclient], AS_HELP_STRING([--with-dhclient=yes|no|path], [Enable dhclient 4.x support]))
 AC_ARG_WITH([dhcpcd], AS_HELP_STRING([--with-dhcpcd=yes|no|path], [Enable dhcpcd 4.x support]))
-- 
1.7.10.4

_______________________________________________
networkmanager-list mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/networkmanager-list

Reply via email to