On Thu, 3 Jul 2014, Chris Hessing wrote:
Nope, the patch didn't seem to fix it. I am seeing the same log output. I also double checked the Network Manager -V output, and it is "0.9.9.0-41.git20131003.fc20" which appears to be the version you wanted me to test.Oh...
I'm also still getting a crash in this call on NetworkManager 0.9.8.8 on Ubuntu 14.04, even after applying the patch from this thread. I think there's one more mistake in the code: dbus-glib expects GTypes, so we need to pass G_TYPE_STRING, not DBUS_TYPE_STRING. See the attached patch.
I'm not able to reliably reproduce this (probably something else I'm doing wrong that's causing NM to use blobs sometimes and files sometimes). I'll run with this for a while and see if it solves the issue, but Chris, I'd be interested in knowing if this fixes the crash for you.
-- Geoffrey Thomas [email protected]
From 6abb3d502b314ce901d5dbed83e2e4573fdbbf0b Mon Sep 17 00:00:00 2001 From: Geoffrey Thomas <[email protected]> Date: Fri, 1 Aug 2014 17:30:54 -0700 Subject: [PATCH] supplicant: fix invalid parameter type in AddBlob D-Bus call Types passed to dbus-glib need to be GTypes, not D-Bus type. While the DBUS_TYPE_G_* macros are GTypes from libdbus-glib, the other DBUS_ types aren't. Signed-off-by: Geoffrey Thomas <[email protected]> --- src/supplicant-manager/nm-supplicant-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/supplicant-manager/nm-supplicant-interface.c b/src/supplicant-manager/nm-supplicant-interface.c index 75450a0..0c84483 100644 --- a/src/supplicant-manager/nm-supplicant-interface.c +++ b/src/supplicant-manager/nm-supplicant-interface.c @@ -1229,7 +1229,7 @@ add_network_cb (DBusGProxy *proxy, DBusGProxyCall *call_id, gpointer user_data) add_blob_cb, blob_info, nm_supplicant_info_destroy, - DBUS_TYPE_STRING, name, + G_TYPE_STRING, name, DBUS_TYPE_G_UCHAR_ARRAY, blobs, G_TYPE_INVALID); nm_supplicant_info_set_call (blob_info, call); -- 1.7.10.4
_______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
