Am 09.02.2015 um 11:20 schrieb Lubomir Rintel: > Hi Michael, > > Thanks you for the patch. > > On Mon, 2015-02-09 at 01:31 +0100, Michael Biebl wrote: >> Only install nm-settings-ifcfg-rh.5 man page if the ifcfg-rh >> configuration plugin has been enabled. It's confusing to have this man >> page around on e.g. a Debian based distro. >> >> See attached patch. >> >> There might be small issue here, i.e. if you build the release tarball >> and you don't have ifcfg-rh enabled, then the nm-settings-ifcfg-rh.5 man >> page would be missing from the release tarball as it's not added to >> EXTRA_DIST >> >> If that is a concern, please let me know and I'll rework to the patch to >> always unconditionally build and dist the man pages, but only install >> them conditionally. > > The distribution tarball contents indeed should not depend on the > configuration configuration options. Please rework it the way you > suggest.
On second thought, the pre-generated man pages are removed on "make clean", so the release tarball can't be built twice in a row. So I wonder if we should bother at all to ship pre-generated man pages. After all, xsltproc is not that an uncommon dependency. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
_______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
