On Fri, 2015-11-13 at 19:35 +0000, Joel Holdsworth wrote: > Hi, here's a patch to make the nmcli build optional. In my use-case I > need to cross-build NetworkManager, and I don't want to have to > cross-build GNU readline for a binary I don't need.
Thanks for the patch! Would you mind making two quick fixes to it? 1) first, the patch will actually break the case where --with-nmcli is not specified on the command-line, because build_nmcli doesn't get set to 'yes' if not specified. You could simply add: if test "$with_nmcli" != no; then AX_LIB_READLINE + build_nmcli=yes else 2) We should put some log info near the bottom whether nmcli is enabled or not, like is done for nmcli. That would be something like: echo " libnm-glib: $with_libnm_glib" +echo " nmcli: $build_nmcli" echo " nmtui: $build_nmtui" echo Any chance you could make those changes and resubmit? Thanks! Dan _______________________________________________ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list