> On 29 March 2017 at 19:58 Dan Williams <[email protected]> wrote: > > On Wed, 2017-03-29 at 16:52 +0100, Colin Helliwell wrote: > > > > On 29 March 2017 at 15:13 Dan Williams <[email protected]> wrote: > > > > > > On Wed, 2017-03-29 at 14:32 +0100, Colin Helliwell wrote: > > > > > > > > > On 27 March 2017 at 14:25 Colin Helliwell <colin.helliwell@ln -sys > > > > > > tems.com> wrote: > > > > > > > > ... > > > > > > > > > > ... but still have subsequent errors which seem to have been > > > > > > due > > > > > > to output directories not having been created e.g. libnm- > > > > > > core, > > > > > > introspection. > > > > > > I can get it to limp a little further by creating the > > > > > > directories > > > > > > in the pre-configure, but not totally. > > > > > > Something perhaps not hooked in right to cater for the build > > > > > > directory being different to the source directory...? > > > > > > > > May I contribute the attached patch for building-outside-source- > > > > directory? Well, as a starting point, at least - there may be > > > > other > > > > build targets which could benefit from a similar mod, but I'm > > > > building with my own (reduced) feature set, so I may not being > > > > seeing > > > > all of them. > > > > Hopefully it helps though. > > > > > > NM should support "srcdir != builddir" already, but sometimes bugs > > > creep into the makefiles. What specific error are you getting from > > > the > > > build process? > >
Ah, I see the reason for the confusion now - my patch is on 1.6, and I see that the changes (and possibly some others) are already in the master version! > > Does this patch make anything better? > > diff --git a/Makefile.am b/Makefile.am > index bacc616..1b9a2b4 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -586,12 +586,12 @@ EXTRA_DIST += \ > libnm-core/crypto_nss.c > > libnm-core/nm-vpn-dbus-types.xml: libnm-core/nm-vpn-dbus-interface.h > tools/enums-to-docbook.pl > > * @$(MKDIR_P) libnm-core/ > * $(AM_V_GEN) @PERL@ $(srcdir)/tools/enums-to-docbook.pl > 'nm-vpn-dbus-types' 'VPN Plugin D-Bus API Types' $< >$@ > > * @$(MKDIR_P) $(top_builddir)/libnm-core/ > * $(AM_V_GEN) @PERL@ $(srcdir)/tools/enums-to-docbook.pl > 'nm-vpn-dbus-types' 'VPN Plugin D-Bus API Types' $< >$(top_builddir)/$@ > > libnm-core/nm-dbus-types.xml: libnm-core/nm-dbus-interface.h > tools/enums-to-docbook.pl > > * @$(MKDIR_P) libnm-core/ > * $(AM_V_GEN) @PERL@ $(srcdir)/tools/enums-to-docbook.pl 'nm-dbus-types' > 'NetworkManager D-Bus API Types' $< >$@ > > * @$(MKDIR_P) $(top_builddir)/libnm-core/ > * $(AM_V_GEN) @PERL@ $(srcdir)/tools/enums-to-docbook.pl 'nm-dbus-types' > 'NetworkManager D-Bus API Types' $< >$(top_builddir)/$@ > > BUILT_SOURCES += \ > libnm-core/nm-vpn-dbus-types.xml \ _______________________________________________ networkmanager-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/networkmanager-list
