On Sat, 14 Apr 2001, Paul J. Reder wrote: > [EMAIL PROTECTED] wrote: > > Please remove any formating issues from the patch. They just clutter what > > you are really doing here. > > Yeah, sorry. Missed those in the lookover. I had played with some code and > put it back wrong. > > > > > > - apr_threadattr_detach_set(thread_attr, 1); > > > + apr_threadattr_detach_set(thread_attr, PTHREAD_CREATE_JOINABLE); > > > > This is a big no-no. You can't use a PTHREAD macro in an apr_thread call. > > Um, ok. Then I should just assume that I can guess that passing 0 will do > the right thing? Or is there an APR equivalent to this that I missed? > The APR code acts like it just wants this parm to be 0/1 (i.e. off or on), > but passes the value straight through to the pthread call (which expects the > enum). I believe passing in zero just does the right thing. I haven't reviewed this code for a long time, but if you look at testthread.c, we don't set it at all, and all of the threads are joined at the end of the program. Ryan _______________________________________________________________________________ Ryan Bloom [EMAIL PROTECTED] 406 29th St. San Francisco, CA 94131 -------------------------------------------------------------------------------
