> > > if ((!fd && !more &&
> > > (nbytes < AP_MIN_BYTES_TO_WRITE) && !APR_BUCKET_IS_FLUSH(e))
> > > || (APR_BUCKET_IS_EOS(e) && c->keepalive)) {
> > >
> > > I think the logic in the conditional is just wrong.
> >
> > I agree completely. I think I can fix this in a few minutes. Watch for a
> > patch.
>
> Hmm. It seems that we'd just want to completely skip the whole thing if fd
> has something in it. So the conditional might be:
>
> if (!fd && ((!more && nbytes < AP_MIN_BYTES_TO_WRITE
> && !APR_BUCKET_IS_FLUSH(e))
> || (APR_BUCKET_IS_EOS(e) && c->keepalive)))
>
> Does that seem right?
I don't think that is enough. We need to also make sure that we don't
have nbytes >= AP_MIN_BYTES_TO_WRITE. The problem is that last
conditional is really just kind of bogus. I am working on a patch, and
should have it soon-ish.
Ryan
_______________________________________________________________________________
Ryan Bloom [EMAIL PROTECTED]
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
