> > > This piece of code is still broken. We should not be calling
> > > apr_bucket_read() on a file bucket unless the file is less than
> > > AP_MIN_SENDFILE_BYTES.
> >
> > This isn't strictly true. If the file is smaller than
> > AP_MIN_BYTES_TO_WRITE, and we are on a keepalive connection, then we will
> > read the file into memory. This is done so that we don't have to allocate
> > the file out of the connection pool.
> >
> > What exactly are you seeing?
>
> Not using apr_sendfile() when we have a file descriptor on a 500 byte file.
Is it a keepalive connection? If so, then we are behaving correctly. We
had to make a trade-off. Either we can use sendfile, or we can buffer
data and send multiple responses in the same packet. We chose the latter.
Ryan
_______________________________________________________________________________
Ryan Bloom [EMAIL PROTECTED]
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
