Re: Allowing modules to add input filters is broken

[Graham Leggett]

Bill Stoddard wrote:

> > This doesn't work - the filter is inserted, but it never runs.
> 
> Read Ryan's response carefully (and my earlier responses this AM).  The
> input filter can filter the request body (not headers).

When I say "filter the headers" I mean "fiddle with the contents of
r->headers_in" after the headers have been read in.

The filter is actually a body filter, but the body is passed through
untouched.

> As I (and now Ryan) have pointed out, the only way to filter headers is to
> hook the pre_connection hook.  But this is a really bad idea for reasons
> mentioned in both of our previous posts.  I think the right thing to do with
> mod_headers is to handle the HeaderIn processing in the request fixup hook,
> not as a filter.

The input filter needs to run after the headers are read in and put in
r->headers, but before the content generator runs.

Regards,
Graham
-- 
-----------------------------------------
[EMAIL PROTECTED]                "There's a moon
                                        over Bourbon Street
                                                tonight..."

S/MIME Cryptographic Signature