On Thu, Jun 07, 2001 at 02:54:53PM -0700, Ian Holsman wrote:
> here is a 'work in progress' for the status patch Greg..
>
> I thought the SNMP crowd might also be interested in this.
>...
Several problems with the patch so far:
1) your formatting is awfully wild. wtf is up with the APR_HOOK_LINK lines
in request.c? your patch needs to observe the style guidelines
2) the hook should not take a request_rec. if you look at the scoreboard's
implementation of the hook, it only uses r->pool. when you think about
it: the hook responder does *not* care about the request that is being
used to fetch this data. in fact, you might not even have one! consider a
monitoring thread that some module started. it would periodically "reach
in" and get status. it certainly does not have a request.
thus, you should just pass a pool
3) forget the apr_table_t. use an apr_hash_t instead.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
