On Sat, 28 Jul 2001, Greg Ames wrote:
> New processes aren't starting up after the seg faults/restarts, because
> there is crap left in the worker_scores, and
> perform_idle_server_maintenance thinks it has plenty of idle workers.
> hmmm, I wonder if the scoreboard cleanup logic in server_main_loop is
> really cleaning out the worker_scores.
>
> perform_idle_server_maintenance doesn't skip over processes from the old
> generation, or process slots with no pid, when it counts idle threads.
> That sounds like a bug that's been around for a while, and just might be
> what's causing problems for Cliff with my patch. It will also fix the
> problem I see where it hangs after all the seg faults. A fix will be
> committed shortly. We still should look at the cleanup logic though.
That definitely sounds like what I was seeing. There was crud in the
scoreboard that just sat there until I gave up my keepalive, at which
point the server sprung back to life with the new generation.
Look forward to the commit. Go ahead and commit your other patch along
with it. I'll test and bump the tag if it checks out. If Ryan wants to
revert a bit later for his single-accept patch, then so be it.
--Cliff
--------------------------------------------------------------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
