From: <[EMAIL PROTECTED]>
Sent: Monday, July 30, 2001 10:11 AM


> stoddard    01/07/30 08:11:40
> 
>   Modified:    .        CHANGES
>                modules/generators mod_cgi.c mod_cgid.c
>   Log:
>   Win32: Get exec cgi tag working.  finfo.protection == 0 on Windows from the
>   apr_stat() call in directory walk (because discovering the permissions on
>   Windows is ridiculously expensive).  All we really need to know is whether the
>   file exists.

Wouldn't it make more sense, in this context, to give up if
rr->finfo.filetype != APR_FILE?  It's the responsibility of
dir walk/file walk to resolve symlinks to their target, so
we shouldn't have to test APR_LNK.

>   -    if (rr->finfo.protection == 0) {
>   +    if (rr->finfo.filetype == 0) {


Reply via email to