Ryan Bloom wrote:

> 2)  I may be wrong, but I believe we have a race-condition.  find_child_by_pid walks 
>the
> scoreboard without locking it.  Since we call that function from the parent whenever 
>a child
> process dies, this looks like a chance for a seg fault, but I am still trying to 
>figure out what 
> I am missing.  Rather than continue to look for my misunderstanding, can somebody 
>explain it
> to me?

[disclosure: I haven't reviewed the patch, but think I understand the
concept]

Is this really a bug?  I would think the list updates always happen in
the single threaded parent process, and not in anything asychronous
(like a signal handler).  If that's true, why would any other code
called synchronously from the parent need to hold the lock?

Greg

Reply via email to