On Wed, Feb 11, 2009 at 11:09:33AM -0600, Tom Haynes wrote:
> Nicolas Williams wrote:
> > 782 + crset_zone_privall(mcred);
> > 783 + if (crsetpriv(mcred, PRIV_FILE_DAC_WRITE,
> > PRIV_FILE_DAC_READ,
> > 784 + PRIV_FILE_DAC_SEARCH, PRIV_FILE_DAC_EXECUTE,
> > PRIV_SYS_MOUNT,
> > 785 + PRIV_FILE_OWNER, NULL)) {
> >
> >Why crsetpriv() when the crset_zone_privall() at 782 should be getting
> >you all those privs anyways?
> >
> >(And if the zone doesn't have some of those, then maybe the user should
> >get what they deserver :)
>
> Okay, I've tested a stock system, a system with the above piece of
> code, and a system without the above piece of code. The stock system
> shows the error and both of the other two test systems do not show the
> error.
>
> That means this code is indeed not needed.
>
> I'm going to keep the old version at the above webrev. I've generated
> a new one at:
>
> http://cr.opensolaris.org/~tdh/krbvariant
Thanks.
You seem to have indented 693-694 by accident.
Looks good!
Please RTI and push ASAP :)
And the EBUSY bug too!
Nico
--
