Thanks Frank. I have added: 71 # 72 # If -l is specified, /usr/sbin/df is used to check the type of the file 73 # system. This extra test is skipped if /usr/sbin/df is not available. 74 # This is acceptable.
and updated the webrev: http://cr.opensolaris.org/~pavelf/6778894/ --Pavel Frank Batschulat (Home) wrote: > On Tue, 16 Dec 2008 14:22:20 +0100, Pavel Filipensky <Pavel.Filipensky at > sun.com> wrote: > > >> this is a fix for "6778894 umountall -l still not really local yet". >> webrev: http://cr.opensolaris.org/~pavelf/6778894/ >> >> Background: My recent fix for "6675447 NFSv4 client hangs >> on shutdown if server is down beforehand" is built on "umountall -l", >> but as noted above umountall -l still not really local yet. >> Unless umountall -l is fixed, the NFSv4 client can still hang >> on shutdown if server is down beforehand. >> > > minor nit, please extend the intro comment: > > 59 # The following /usr based commands may be used by this script > (depending on > 60 # command line options). We will set our PATH to find them, but where > they > 61 # are not present (eg, if /usr is not mounted) we will catch references > to > 62 # them via shell functions conditionally defined after option processing > 63 # (don't use any of these commands before then). > 64 # > 65 # Command Command line option and use > 66 # /usr/bin/sleep -k, to sleep after an fuser -c -k on the > mountpoint > 67 # /usr/sbin/fuser -k, to kill processes keeping a mount point busy > > to mention the use of /usr/sbin/df too. > > other then that, ship it! > > --- > frankB > > _______________________________________________ > nfs-discuss mailing list > nfs-discuss at opensolaris.org >
