Hi, to avoid confusion with outdated webrevs - the latest webrev is here
http://cr.opensolaris.org/~pavelf/6778894-v3 the review was finished by Nico. Since then, I have done 2 minor changes: * renamed NFS_LIST to nfslist (to keep the naming consistent) * re-phrased the WARNING (removed the CR number) --Pavel Pavel Filipensky wrote: > Nicolas Williams wrote: > >> On Wed, Dec 17, 2008 at 06:31:05PM +0100, Pavel Filipensky wrote: >> >>> I have updated the comments, new webrev is here (it also contains the >>> latest umountall changeset from today): >>> >>> http://cr.opensolaris.org/~pavelf/6778894-v3 >>> >>> Can you give an explicit review of this workspace? >>> >> You need to explicitly set NFS_LIST= the empty string, otherwise if >> NFS_LIST happens to be set in the environment when unmountall runs... >> > > Thanks for catching this. I have added: > 246 NFS_LIST="" > > webrev is updated http://cr.opensolaris.org/~pavelf/6778894-v3 > > --Pavel > > > >> I think I have a better way to deal with the whitespace issues too, >> including newlines. I'll send a reply on the other thread sometime >> after lunch. >> > > _______________________________________________ > nfs-discuss mailing list > nfs-discuss at opensolaris.org >
