Tom, I didn't see any issues in the code changes, but I'll let others comment.
However, I see several minor differences in the Makefile and non-C file license/copyright blocks being used (especially in the prototype* files), and recommend updating the files to consistently use the standard prototype at: http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/prototype.Makefile Which has these sections: - CDDL header block - one blank line - Copyright block - one blank line Also, the C files can be cleaned up accordingly using this as a guide: http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/prototype.c Cheers, Jim Tom Haynes wrote: > I'm sponsoring a fix for Shawn Walker. (see > http://www.opensolaris.org/jive/thread.jspa?messageID=153406) > > The terse bug description is at: > http://bugs.opensolaris.org/view_bug.do?bug_id=6397024 > > And the webrev is at: > > http://cr.opensolaris.org/~tdh/6397024/ > > The basic issue is that the help output from a nfs umount is wrong: > > # /usr/lib/fs/nfs/umount > Usage: nfs umount [-o opts] {server:path | dir} > > The only flag allowed is -f, so this is the desired output: > > # /usr/lib/fs/nfs/umount > Usage: nfs umount [-f] {server:path | dir} > > _______________________________________________ > nfs-discuss mailing list > nfs-discuss at opensolaris.org -- Jim Walker, http://blogs.sun.com/jwalker Sun Microsystems, Software, Solaris QE x77744, 500 Eldorado Blvd, Broomfield CO 80021
