On 6/26/15 6:05 PM, Frank Filz wrote:
> I ran into a problem with Bill's patch set where it immediately crashed
> while running pynfs 4.1.
>
Frank points to the very first substantive patch in the series.

Date: Thu, 14 May 2015 15:58:24 -0400
Subject: [PATCH 04/17] Redundant hostaddr storage in nfs_worker_data

https://review.gerrithub.io/#/c/236498/

I had to remove the redundant worker reference, because RDMA doesn't
have the worker (it uses its own pool), so it crashed trying to
access the hostaddr.  That was almost the first thing I fixed....

(I re-dated as I squashed things for publication.)

Since that is very straightforward, it is actually not the problem
itself.  Instead, there apparently is a bug in the current dev- code
that fails to copy (svc.h)

struct netbuf xp_rtaddr;        /* remote transport address */

into

struct sockaddr_in6 xp_raddr;   /* remote addr (backward ABI compat) */

Of course, it's always a terrible idea to have more than 1 copy of
the same data.  Somebody screwed the pooch.


> I'm not sure if it was an issue with the rebase I did or what.
>
I don't have this problem, because I have a later patch in my set
that combines them to avoid any copy:

Date: Tue, 16 Jun 2015 15:17:29 -0400
Subject: [PATCH 14/17] Combine xp_ addresses into new struct rpc_address

Oh well, I'll push some of my more recent changes into the set....


> Originally I was not planning on doing a merge next week. If we can get
> Bill's patch set rebased onto V2.3-dev-9 and passing all tests by Wednesday,
> I will cut a merge with JUST Bill's patches.
>


------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors 
network devices and physical & virtual servers, alerts via email & sms 
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
Nfs-ganesha-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Reply via email to