> Thanks, Fredric. > > This is a false positive; even though the switch is on a locally defined > enumeration, the actual value comes off the wire, and so could be outside > the enumeration. This will be caught by the default clause, and > -1 will be returned.
Hmm, I guess I should have looked at the code more carefully when reviewing... Using an enum for flag values that will be or-red together is not very useful and probably confusing. Note that any combination of flags is not a valid enum value... Just use #define to define the constants. I would also change the value of PAN_FS_ACE_INVALID to non-zero and return that from the function rather than casting -1. Frank > On 06/30/2015 02:35 AM, SAUNIER, FREDERIC wrote: > > Hi Daniel, > > > > There is actually only one issue (reported by 2 different instances of > coverity). > > All details are available on online version at > https://scan.coverity.com/projects/2187/view_defects. > > If you are not registered yet to scan.coverity.com (you can either > > sign up requesting a dedicated free account, or using your github account) , > here are the details for convenience: > > > > src//nfs-ganesha/src/FSAL/FSAL_VFS/panfs/attrs.c:line 294 > > CID 120979 (#1 of 1): Operands don't affect result > (CONSTANT_EXPRESSION_RESULT) > > result_independent_of_operands: panace->info == 4294967295U /* > (uint32_t)-1 */ is always false regardless of the values of its operands. This > occurs as the logical operand of if. > > > > Hope this helps, > > -- Frederic > > > > -----Original Message----- > > From: Daniel Gryniewicz [mailto:[email protected]] > > Sent: Monday, June 29, 2015 2:53 PM > > To: [email protected] > > Subject: Re: [Nfs-ganesha-devel] V2.3-dev-9 Coverity status > > > > On 06/29/2015 08:48 AM, SAUNIER, FREDERIC wrote: > >> Hi, > >> This week, coverity analysis reports 2 new defects. Online Coverity > >> results are available. > >> Analysis summary report: > >> ------------------------ > >> Files analyzed : 489 > >> Total LoC input to cov-analyze : 193248 > >> Functions analyzed : 4608 > >> Paths analyzed : 684454 > >> Here is updated list of outstanding defects. > >> Cheers, > >> Frederic > >> > > Hi, Fredric. > > > > The PanFS attr ones are clearly introduced by my patches. How do I find > details about them? > > > > Thanks, > > Daniel > > > > ---------------------------------------------------------------------- > > -------- Monitor 25 network devices or servers for free with > > OpManager! > > OpManager is web-based network management software that monitors > > network devices and physical & virtual servers, alerts via email & sms > > for fault. Monitor 25 devices for free with no restriction. Download > > now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o > > _______________________________________________ > > Nfs-ganesha-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel > > > > ---------------------------------------------------------------------- > > -------- Don't Limit Your Business. Reach for the Cloud. > > GigeNET's Cloud Solutions provide you with the tools and support that > > you need to offload your IT needs and focus on growing your business. > > Configured For All Businesses. Start Your Cloud Today. > > https://www.gigenetcloud.com/ > > _______________________________________________ > > Nfs-ganesha-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel > > > ---------------------------------------------------------------------------- -- > Don't Limit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that you > need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ > _______________________________________________ > Nfs-ganesha-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel ------------------------------------------------------------------------------ Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business. Configured For All Businesses. Start Your Cloud Today. https://www.gigenetcloud.com/ _______________________________________________ Nfs-ganesha-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
