On Mon, Jul 27, 2015 at 09:22:50AM -0500, Malahal Naineni wrote:
> Niels de Vos [nde...@redhat.com] wrote:
> > On Sun, Jul 26, 2015 at 11:00:29AM -0700, Krishna Harathi wrote:
> > > Can someone point me to a fix submission process document or a summary?
> > > 
> > > I looked at Ganesha wiki as well as read some past email. I came across
> > > some recent
> > > email from Frank and others on this subject,  but I am not clear on the
> > > process.
> > 
> > I think this is the page and section that should help you:
> > 
> >   
> > https://github.com/nfs-ganesha/nfs-ganesha/wiki/DevPolicy#patch-submission-guidelines
> > 
> > Basically, you need to create an account (with your GitHub credentials)
> > on http://gerrithub.io and add a public ssh-key in your account
> > settings. After that, you should clone (or add the remote) based on this
> > URL
> > 
> >   $ git clone 
> > ssh://${GITHUB_USERNAME}@review.gerrithub.io:29418/ffilz/nfs-ganesha
> 
> We still use github branch (not gerrithub) as the official repo, right?
> In any case, I actually cloned my repo from
> 
> https://github.com/nfs-ganesha/nfs-ganesha.git
> 
> I have gerrithub remote "https://gerrithub.io/ffilz/nfs-ganesha";
> exclusively for pushing patches.

I dont know if that makes a difference. The github.com is probably the
"official" repository, but it should be in sync with what gerrithub
provides.

> > Patches are sent against the "next" branch, and it is easiest to create
> > one branch per patch(-series):
> > 
> >   $ git checkout -t -b my-fixes-for-foo origin/next
> > 
> > Once you have committed and tested your changes, you can push them to
> > gerrithub. I prefer to use the git-review tool for that:
> > 
> >   $ git review -t my-fixes-for-foo
> 
> Is the "review" command specific to gerrithub? I use it to download
> someone else patch(es) from gerrithub. It just hung on a regular commit!
> I use "git difftool" for reviewing my own patch(es).

git-review is specific to Gerrit. I only use it to post my own changes
and download changes from others for review, but it can do more. The
only reason I can think of why it would hang, is when you have multiple
git remotes in your repository, and git-review tries to use an incorrect
one. You could try posting your change with

  $ git review -r gerrithub -t my-fixes-for-foo

Cheers,
Niels

------------------------------------------------------------------------------
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Reply via email to