On 10/19/2015 09:35 AM, Daniel Gryniewicz wrote: > On Mon, Oct 19, 2015 at 9:13 AM, Swen Schillig <s...@vnet.ibm.com> wrote: >> I'm not talking about recovery, >> just about how and where to end a program. >> ...and I still believe a log-function is not the right place to that. > > I've always viewed a fatal log function as an abort (and an abort as a > fatal log function, since you shouldn't ever have one without the > other). That said, I'd prefer not to have thousands of lines of > untested error checking code just to allow us to exit all the way back > to main to we can abort. I prefer to abort at the time of failure. > It's more likely to leave useful information in a backtrace or in the > log. Note that the only non-main() exit in Ganesha is the Fatal() > abort function, so I consider it a single point of exit anyway.
+1 A useful backtrace is a big plus in my book. -- Kaleb ------------------------------------------------------------------------------ _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel