Kaleb KEITHLEY [[email protected]] wrote: > On 03/17/2016 09:19 AM, Malahal Naineni wrote: > >Kaleb, the tag you made V2.3.1 actually points to 2.3.0-1 version in its > >src/CMakeLists.txt file. You should have at least changed > >src/CMakeLists.txt file reflect V2.3.1 version before tagging. > > Ugh. I forgot about that. :-( > > > > >I back ported some patches on top of V2.3.0-1 and called it V2.3.1. To > >avoid "tag" vs "actual version" confusion, we should do the following: > > > >1. Move the existing V2.3.1 tag point to to actual V2.3.1 version. > >2. If #1 is not desired for some odd reason, I should at least make the > > new version as V2.3.1-1 and tag it as V2.3.1-1. > > > >I am fine with #2, but we still leave some confusion if we don't do #1. > > For Red Hat and Fedora, 2.3.1-x means Release (or build) X of > Version 2.3.1. Usually what this means for is is we use the 2.3.1 > tar file and may make various changes to the RPM spec file > (including applying patches) and these are 2.3.1-1, 2.3.1-2, > 2.3.1-3, etc. over the life of 2.3.1 > > So for us it would be better if the next tag or release is V2.3.2.
It does mean the upstream should NOT have extra version ever. It is for the distros to add that. I agree, let us go by 2.3.x where x monotonically increases for every update I or you make, and distro can make 2.3.x-y versions for shipment. 1. If you want, I can replace 2.3.0-1 with 2.3.1 version and can move your tag to point to that 2.3.1 (just one commit changing the CMAKE file). Then I will rebase my patches that I did today on top of that and name it 2.3.2. 2. My back ported today's patches are very minor, so if you don't care what V2.3.1 tag points to, we make move the tag to current checked in 2.3.1. 3. If you don't want to change any history at this point, I will change the current HEAD with 2.3.2 (instead of 2.3.1) and tag it as V2.3.2. Let me know which option (#1, #2 or #3) you like. All of them need trivial changes, so doing any of those is no big deal. #1 or #2 make it very clean, but #3 leaves V2.3.1 tag pointing to V2.3.0-1 (looks odd, that is all). Frank and others, any comments? Regards, Malahal. ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Nfs-ganesha-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
