Hi, I'm not sure of the defines on the ntirpc side should be removed at this point. Let's focus on getting these changes carefully reviewed and stress tested...
Matt ----- Original Message ----- > From: "William Allen Simpson" <[email protected]> > To: "NFS Ganesha Developers" <[email protected]> > Sent: Thursday, March 31, 2016 2:30:39 PM > Subject: Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Remove > unused dispatch send lock defines > > On 3/31/16 3:31 AM, GerritHub wrote: > >>From <[email protected]>: > > > > [email protected] has uploaded a new change for review. > > > > https://review.gerrithub.io/270984 > > > > Change subject: Remove unused dispatch send lock defines > > ...................................................................... > > > > Remove unused dispatch send lock defines > > > > Change-Id: If5fa84e2a8e1d846f23a7f8189adac47d7810c75 > > Signed-off-by: William Allen Simpson <[email protected]> > > --- > > M src/include/gsh_rpc.h > > 1 file changed, 0 insertions(+), 23 deletions(-) > > > > > > git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha > > refs/changes/84/270984/1 > > > Added this last night, as I realized I'd forgotten to remove the > unused defines. > > These were doing lock/unlock for TCP sends during errors that had > already been converted to MT-safe on ntirpc side. > > The define that would have checked the lock is not used anywhere: > rpc_dplx_swf() > > I'll try to remember to remove it in a future ntirpc-side patch. > > > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with > Intel Data Analytics Acceleration Library. > Click to learn more. > http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140 > _______________________________________________ > Nfs-ganesha-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel > -- Matt Benjamin Red Hat, Inc. 315 West Huron Street, Suite 140A Ann Arbor, Michigan 48103 http://www.redhat.com/en/technologies/storage tel. 734-707-0660 fax. 734-769-8938 cel. 734-216-5309 ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140 _______________________________________________ Nfs-ganesha-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
