On Wed, Apr 6, 2016 at 7:51 PM, Frank Filz <[email protected]> wrote:
> In nfs4_op_open.c:
>
> @@ -1863,10 +1871,6 @@ int nfs4_op_open(struct nfs_argop4 *op,
> compound_data_t *data,
>                                                              &obj,
>                                                              &created);
>                         if (res_OPEN4->status == NFS4_OK) {
> -                               /* Decrement the current entry here, because
> -                                * nfs4_create_fh replaces the current fh.
> -                                */
> -                               set_current_entry(data, NULL);
>                                 res_OPEN4->status = open4_create_fh(data,
> obj);
>                         }
>                 }
>
> Not quite clear why this was removed.

set_current_entry() properly handles changing existing handles, so
this is now redundant.

>
> In nfs4_op_readdir.c, the following code chunk seems to have been removed:
>
>         /* Cleanup after problem with junction processing. */
>         if (cb_state == CB_PROBLEM) {
>                 /* Restore the export. */
>                 restore_data(tracker);
>                 return CACHE_INODE_SUCCESS;
>         }
>
> Is this no longer necessary?

Lost that, sorry.  It's back.

Daniel

------------------------------------------------------------------------------
_______________________________________________
Nfs-ganesha-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Reply via email to