> 1. did you really mean you think it should always be based on ctim? Per this page: http://www.linux-faqs.info/general/difference-between-mtime-ctime-and-atime
Ctime is updated for any change to the file, metadata or data. Mtime is not updated if only metadata is changed. > 2. we should probably allow FSAL's to override Ganesha's default mtime > behavior, e.g., for AFS or DCE every vnode has a monotonically increasing > version number (that's called out in RFC5661 or an errata by David Noveck, I > can't recall which) Yes, if an FSAL has access to a more reliable change attribute than ctime/mtime, it should adjust change after posix2fsal_attributes is called if it otherwise uses that function. Frank > > I have pushed my latest version of patches that includes removing the > > attributes from the fsal_obj_handle, and also copy them out on creates > > and lookups. > > > > I am having issues with pynfs SATT15 test case. Something is causing > > the change attribute to roll back, such that it doesn't appear to > > change. > > > > Ganesha is faking things up to make this test pass, but I wonder, we > > currently base change attribute on the greater of mtim or ctim. My > > suspicion is that it should only be based on ctim, but even doing that > > is not sufficient to make SATT15 pass without the code inside the #if > > 0 in mdcache_refresh_attrs that prevents rolling back change. > > > > I think we need to have a discussion about how to best maintain a > > change attribute. > > > > Thanks > > > > Frank > > > > > > > > --- > > This email has been checked for viruses by Avast antivirus software. > > https://www.avast.com/antivirus > > > > > > ---------------------------------------------------------------------- > > -------- Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T > > Park in San Francisco, CA to explore cutting-edge tech and listen to > > tech luminaries present their vision of the future. This family event > > has something for everyone, including kids. Get more information and > > register today. > > http://sdm.link/attshape > > _______________________________________________ > > Nfs-ganesha-devel mailing list > > Nfs-ganesha-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel > > -- > Matt Benjamin > CohortFS, LLC. > 315 West Huron Street, Suite 140A > Ann Arbor, Michigan 48103 > > http://cohortfs.com > > tel. 734-761-4689 > fax. 734-769-8938 > cel. 734-216-5309 --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus ------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
