Hi Frank, Why do we have reopen2 as one of the multi-fd support, I thought that one of the resones for multi fd is so we don't have to reopen files when we get differnet/conflicting open options.
Marc. From: GerritHub <supp...@gerritforge.com> To: Marc Eshel/Almaden/IBM@IBMUS Cc: CEA-HPC <gerrithub-...@cea.fr>, Matt Benjamin <mbenja...@redhat.com>, Gluster Community Jenkins <gerrit...@gluster.org>, openstack-ci-service+rdo-ci-cen...@redhat.com Date: 07/25/2016 03:13 PM Subject: Change in ffilz/nfs-ganesha[next]: Make a direct call to state_add_impl() with lock held. >From Frank Filz <ffilz...@mindspring.com>: Frank Filz has posted comments on this change. Change subject: Make a direct call to state_add_impl() with lock held. ...................................................................... Patch Set 3: (1 comment) https://review.gerrithub.io/#/c/285191/3/src/Protocols/NFS/nfs4_op_layoutget.c File src/Protocols/NFS/nfs4_op_layoutget.c: Line 186: if (clientid_owner->so_type != STATE_CLIENTID_OWNER_NFSV4) { > so why do we have it in state_add() ? Too much CYA programming in Ganesha?.... With the code path you have here, I'm pretty sure you're guaranteed that this is all right... -- To view, visit https://review.gerrithub.io/285191 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fb6f65a7545c63adf6adc09084763932bae591a Gerrit-PatchSet: 3 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: es...@us.ibm.com Gerrit-Reviewer: CEA-HPC <gerrithub-...@cea.fr> Gerrit-Reviewer: Frank Filz <ffilz...@mindspring.com> Gerrit-Reviewer: Gluster Community Jenkins <gerrit...@gluster.org> Gerrit-Reviewer: Matt Benjamin <mbenja...@redhat.com> Gerrit-Reviewer: es...@us.ibm.com Gerrit-Reviewer: openstack-ci-service+rdo-ci-cen...@redhat.com Gerrit-HasComments: Yes ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
