On Wed, Aug 10, 2016 at 05:04:52PM -0500, Malahal Naineni wrote: > Matt, I did merge all the requests you made, but commit 8191f7 (66392e > in my V2.3-stable branch) is giving unusual warning. Can you please > check? The commit didn't result in any merge conflict. Same code in > ganesha2.4 version doesn't give this warning. I saw this warning on > RHEL7 with gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4). If I replace > the array with alloca(), then the warning goes away. I don't want to > check in the patch with this warning! Looks like a compiler issue to > me though! > > Here is the warning: > [ 91%] Building C object idmapper/CMakeFiles/idmap.dir/idmapper.c.o > In file included from > /home/malahal/work/src/nfs-ganesha/src/libntirpc/ntirpc/rpc/xdr_inline.h:51:0, > from > /home/malahal/work/src/nfs-ganesha/src/include/gsh_rpc.h:17, > from /home/malahal/work/src/nfs-ganesha/src/include/nfs4.h:5, > from > /home/malahal/work/src/nfs-ganesha/src/include/gsh_config.h:49, > from > /home/malahal/work/src/nfs-ganesha/src/include/cache_inode.h:62, > from > /home/malahal/work/src/nfs-ganesha/src/include/export_mgr.h:40, > from > /home/malahal/work/src/nfs-ganesha/src/include/nfs_exports.h:48, > from > /home/malahal/work/src/nfs-ganesha/src/idmapper/idmapper.c:47: > In function ‘inline_xdr_bytes.constprop.3’, > inlined from ‘xdr_encode_nfs4_princ’ at > /home/malahal/work/src/nfs-ganesha/src/idmapper/idmapper.c:124:3: > /home/malahal/work/src/nfs-ganesha/src/libntirpc/ntirpc/rpc/types.h:194:33: > warning: attempt to free a non-heap object ‘namebuf’ > [-Wfree-nonheap-object] > #define mem_free(ptr, size) free(ptr) > ^ > /home/malahal/work/src/nfs-ganesha/src/libntirpc/ntirpc/rpc/xdr_inline.h:579:4:note: > in expansion of macro ‘mem_free’ > mem_free(sp, nodesize); > ^ > Linking C static library libidmap.a
Thanks for merging the patches. I've done scratch builds in the CentOS Community Build System where the Storage SIG will use the new version after it has been released. The EL6 version builds without issues, but EL7 hits the same compiler problem as posted above: http://cbs.centos.org/kojifiles/work/tasks/4769/104769/build.log The CentOS-6 build logs for the different architectures can be found under the "task info" URL. RPMs and build logs are available: $ cbs build --scratch storage6-gluster-38-el6 nfs-ganesha-2.3.3-0.1.el6.src.rpm Uploading srpm: nfs-ganesha-2.3.3-0.1.el6.src.rpm [====================================] 100% 00:00:06 2.70 MiB 417.80 KiB/sec Created task: 104765 Task info: https://cbs.centos.org/koji/taskinfo?taskID=104765 Watching tasks (this may be safely interrupted)... 104765 build (storage6-gluster-38-el6, nfs-ganesha-2.3.3-0.1.el6.src.rpm): open (x86_64-2.cbs.centos.org) 104767 buildArch (nfs-ganesha-2.3.3-0.1.el6.src.rpm, i686): free 104766 buildArch (nfs-ganesha-2.3.3-0.1.el6.src.rpm, x86_64): open (x86_64-3.cbs.centos.org) 104767 buildArch (nfs-ganesha-2.3.3-0.1.el6.src.rpm, i686): free -> open (x86_64-2.cbs.centos.org) 104766 buildArch (nfs-ganesha-2.3.3-0.1.el6.src.rpm, x86_64): open (x86_64-3.cbs.centos.org) -> closed 0 free 2 open 1 done 0 failed 104767 buildArch (nfs-ganesha-2.3.3-0.1.el6.src.rpm, i686): open (x86_64-2.cbs.centos.org) -> closed 0 free 1 open 2 done 0 failed 104765 build (storage6-gluster-38-el6, nfs-ganesha-2.3.3-0.1.el6.src.rpm): open (x86_64-2.cbs.centos.org) -> closed 0 free 0 open 3 done 0 failed 104765 build (storage6-gluster-38-el6, nfs-ganesha-2.3.3-0.1.el6.src.rpm) completed successfully Niels > > On Tue, Aug 9, 2016 at 8:49 AM, Matt Benjamin <[email protected]> wrote: > > Hi Malahal, > > > > Would you consider also taking the following commits: > > > > commit 86f502ebede604720801c3514fd3326c55eff2c9 > > Author: Frank S. Filz <[email protected]> > > Date: Fri Aug 5 14:37:42 2016 -0700 > > > > Tweak FindCephFS.cmake and FindRGW.cmake > > > > commit 399da8850cab9f4ad9ffb1ccff198847975b7de5 > > Author: Daniel Gryniewicz <[email protected]> > > Date: Tue Aug 2 15:02:06 2016 -0400 > > > > find_package implementation for CEPH FSALs > > > > commit 1c45f6a8f91c266e6d9ff236294cb2ac6987e2d0 > > Author: Matt Benjamin <[email protected]> > > Date: Wed Jul 20 12:25:48 2016 -0400 > > > > rgw: add 3 new config options > > > > commit 8191f7c5f712caaf04f9213c8908904b63229da5 > > Author: Matt Benjamin <[email protected]> > > Date: Wed Jul 13 12:51:46 2016 -0400 > > > > idmapping: add only_numeric_owners option (off by default) > > > > commit ada6806243e40c3a2a5eba3f45f5f7cb3902a114 > > Author: Matt Benjamin <[email protected]> > > Date: Wed Jul 6 16:39:39 2016 -0400 > > > > RGW: look for librgw.so in either lib or lib64 > > > > > > Thanks, > > > > Matt > > > > ----- Original Message ----- > >> From: "Malahal Naineni" <[email protected]> > >> To: [email protected] > >> Sent: Monday, August 8, 2016 7:48:07 PM > >> Subject: [Nfs-ganesha-devel] New patch level release V2.3.3 > >> > >> I created a new V2.3.3 patch level release. Picked up all requested > >> patches as well as others (some nice to have fixes in addition to real > >> issues) that I thought should be in V2.3-stable. Please let me know > >> if anything else needs to be added. If you think something should not > >> be present, let us remove it as well. > >> > >> The code passes pynfs and cthon. No other tests are done yet. > >> > >> Here is a github link to the commits: > >> > >> https://github.com/malahal/nfs-ganesha/commits/V2.3-stable > >> > >> Here are the commits, authors, please see if merge happened right or not! > >> > >> $ git log --pretty=format:"%h, %ae, %s" -25 > >> 5a631eb, [email protected], Version V2.3.3 > >> 20415fa, [email protected], Add COMPONENT_TIRPC for tracing libntirpc > >> eb7bc11, [email protected], Clean up log setting functions > >> f1c5a45, [email protected], This patch is to fix the bug that > >> changes the owner always to root when all_s > >> 2709954, [email protected], Rescan /etc/mtab in GPFS and VFS > >> FSALs one more time if claim_posix_filesystems f > >> e0839c6, [email protected], Chomp tailing slash from pseudopath > >> 8badbf9, [email protected], FSAL_GLUSTER/Upcall: Change poll interval to > >> 10us > >> 187e17a, [email protected], Explicitly set privilegedport to false in > >> default PseudoFS export > >> e86bb22, [email protected], [state_misc.c] Remove assert() for invalid > >> owner type. > >> b85b59d, [email protected], Add ATTR_FSID to NFS v3 attributes > >> 8e3066b, [email protected], NFSv3 SETATTR should NOT set > >> ATTR_SPACEUSED when ATTR_SIZE is set > >> bd44577, [email protected], Remove duplicate definition of > >> posix2fsal_attributes > >> 6dce744, [email protected], FSAL_GLUSTER : symlink operation fails > >> when acl is enabled > >> d25538a, [email protected], [fridgethr.c] Prevent infinite loop for > >> timed out sync. > >> 9b08e7b, [email protected], Stop MOUNT/NLM as additional services in > >> NFSv4 only environments > >> 73763ac, [email protected], Handle clientid and client record > >> decoupling in nfs_release_v4_client() > >> 72b9ba1, [email protected], [nfs4_clientid.c] remove stale client_id > >> reference from client_record > >> 5888396, [email protected], Avoid setting socket max buffers > >> a28389d, [email protected], FSAL_GLUSTER: set default errno to EINVAL > >> 5de5e45, [email protected], RPCSEC_GSS: When using kerberos validate > >> principals but not handles > >> 0f27c4a, [email protected], [FSAL_GPFS] prevent negative values to be > >> interpreted as read amount. > >> b19da77, [email protected], FSAL_GLUSTER : adding logrotate file for > >> ganesha-gfapi.log > >> d003ce2, [email protected], fsal_gluster: eliminate duplicate code > >> in gluster2fsal_error() > >> e4e210f, [email protected], nfs: Use option grace_period to determine > >> grace timeout > >> d51394b, [email protected], V2.3.2 > >> > >> ------------------------------------------------------------------------------ > >> What NetFlow Analyzer can do for you? Monitors network bandwidth and > >> traffic > >> patterns at an interface-level. Reveals which users, apps, and protocols > >> are > >> consuming the most bandwidth. Provides multi-vendor support for NetFlow, > >> J-Flow, sFlow and other flows. Make informed decisions using capacity > >> planning reports. http://sdm.link/zohodev2dev > >> _______________________________________________ > >> Nfs-ganesha-devel mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel > >> > > > > -- > > Matt Benjamin > > Red Hat, Inc. > > 315 West Huron Street, Suite 140A > > Ann Arbor, Michigan 48103 > > > > http://www.redhat.com/en/technologies/storage > > > > tel. 734-707-0660 > > fax. 734-769-8938 > > cel. 734-216-5309 > > ------------------------------------------------------------------------------ > What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic > patterns at an interface-level. Reveals which users, apps, and protocols are > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > J-Flow, sFlow and other flows. Make informed decisions using capacity > planning reports. http://sdm.link/zohodev2dev > _______________________________________________ > Nfs-ganesha-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev
_______________________________________________ Nfs-ganesha-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
