>From <jlay...@redhat.com>: jlay...@redhat.com has uploaded a new change for review.
https://review.gerrithub.io/295458 Change subject: Have posix2fsal_attributes use the posix standard for time fields by default ...................................................................... Have posix2fsal_attributes use the posix standard for time fields by default Currently if we were building on anything other than FreeBSD or Linux, posix2fsal_attributes would not fill out the time fields, but would leave the ATTR_* flags for them set. POSIX.1-2008 specifies the st_[acm]tim fields in the stat structure, so that's not just a Linux thing. Any POSIX compliant OS should provide that, and indeed recent versions of FreeBSD have compatability macros for those fields. Let's just make posix2fsal_attributes use the POSIX timespec fields by default, and only conditionally do something special for FreeBSD. I would say we just do the POSIX thing universally, but I'm not sure if there might be old FreeBSD versions that require this. Regardless, with this any platform that doesn't provide those fields will fail to compile instead of handing out bogus timestamp values at runtime, which I think is preferable. Also, there is no need to conditionally handle the chgtime value, if we compare the already-copied fields here. Unify that as well. Change-Id: Iac57ba4a9f44baa83e1507006043ded5dd107cb5 Signed-off-by: Jeff Layton <jlay...@redhat.com> --- M src/FSAL/fsal_convert.c 1 file changed, 8 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/58/295458/1 -- To view, visit https://review.gerrithub.io/295458 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iac57ba4a9f44baa83e1507006043ded5dd107cb5 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: jlay...@redhat.com ------------------------------------------------------------------------------ _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
