>From Frank Filz <ffilz...@mindspring.com>: Frank Filz has uploaded a new change for review.
https://review.gerrithub.io/299006 Change subject: Separate struct attrlist mask into request_mask and valid_mask ...................................................................... Separate struct attrlist mask into request_mask and valid_mask This allows us to properly manage attribute and ACL validity. Several expectations are now relevant: fsal_prepare_attrs sets valid_mask to 0. The FSAL MUST only set bits in valid mask corresponding to attributes it has fetched. There may be more bits set in valid_mask than are set in request_mask. The request_mask indicates the attributes desired. FSAL_MDCACHE does not ask for ATTR_ACL on any request that returns a new fsal_obj_handle. FSALs probably SHOULD check in those functions that ATTR_ACL is not requested since none of them necessarily supply an ACL. setattrs and setattr2 only look at the valid_mask. I've probably missed some things, reviewers keep me honest... Change-Id: I8ce1ed5a7a0ad0a0ccc3a0b1d885f9588fd50873 Signed-off-by: Frank S. Filz <ffilz...@mindspring.com> --- M src/FSAL/FSAL_CEPH/export.c M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/export.c M src/FSAL/FSAL_GLUSTER/gluster_internal.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_GPFS/export.c M src/FSAL/FSAL_GPFS/file.c M src/FSAL/FSAL_GPFS/fsal_attrs.c M src/FSAL/FSAL_GPFS/fsal_convert.c M src/FSAL/FSAL_GPFS/fsal_up.c M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/FSAL_PROXY/handle.c M src/FSAL/FSAL_PSEUDO/handle.c M src/FSAL/FSAL_RGW/export.c M src/FSAL/FSAL_RGW/handle.c M src/FSAL/FSAL_VFS/file.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/FSAL_VFS/panfs/attrs.c M src/FSAL/FSAL_VFS/panfs/handle.c M src/FSAL/FSAL_ZFS/handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c M src/FSAL/access_check.c M src/FSAL/commonlib.c M src/FSAL/fsal_convert.c M src/FSAL/fsal_helper.c M src/Protocols/9P/9p_lcreate.c M src/Protocols/9P/9p_mkdir.c M src/Protocols/9P/9p_setattr.c M src/Protocols/9P/9p_symlink.c M src/Protocols/NFS/nfs3_create.c M src/Protocols/NFS/nfs3_mkdir.c M src/Protocols/NFS/nfs3_mknod.c M src/Protocols/NFS/nfs3_readdirplus.c M src/Protocols/NFS/nfs3_setattr.c M src/Protocols/NFS/nfs3_symlink.c M src/Protocols/NFS/nfs4_op_create.c M src/Protocols/NFS/nfs4_op_nverify.c M src/Protocols/NFS/nfs4_op_open.c M src/Protocols/NFS/nfs4_op_setattr.c M src/Protocols/NFS/nfs4_op_verify.c M src/Protocols/NFS/nfs_proto_tools.c M src/include/fsal.h M src/include/fsal_api.h M src/include/fsal_types.h M src/support/nfs_creds.c 49 files changed, 647 insertions(+), 667 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/06/299006/1 -- To view, visit https://review.gerrithub.io/299006 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8ce1ed5a7a0ad0a0ccc3a0b1d885f9588fd50873 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz <ffilz...@mindspring.com> ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
