>From Gui Hecheng <guim...@126.com>: Gui Hecheng has uploaded a new change for review.
https://review.gerrithub.io/300909 Change subject: FSAL_VFS: fix segfault when export two subdirs with FSAL_VFS and FSAL_XFS ...................................................................... FSAL_VFS: fix segfault when export two subdirs with FSAL_VFS and FSAL_XFS I export 2 subdirs /dir1, /dir2 of a xfs filesystem, /dir1 with FSAL_XFS and /dir2 with FSAL_VFS. This export behavior results with only /dir1 exported successfully which is expected. But when I try to do 'systemctl stop nfs-ganesha', I got a segfault: kernel: ganesha.nfsd[58288]: segfault at 7f757901a340 ip 00007f757901a340 \ sp 00007f74ef4e94b8 error 15 This is because the failed export of /dir2 forgets to cleanup the export entry of the FSAL_VFS module upon failure, and the destroy_fsals() got bad pointers. Adding a detach_export will fix it. I tried to clarify the err return paths at the same time. Change-Id: I02b91e19c789bbf34a8aeda14c3a3faba814bc8b Signed-off-by: Gui Hecheng <guihech...@cmss.chinamobile.com> --- M src/FSAL/FSAL_VFS/export.c 1 file changed, 12 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/300909/1 -- To view, visit https://review.gerrithub.io/300909 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I02b91e19c789bbf34a8aeda14c3a3faba814bc8b Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Gui Hecheng <guim...@126.com> ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
